This repository was archived by the owner on Aug 6, 2025. It is now read-only.
Conversation
casthewiz
reviewed
Mar 15, 2022
api/controllers/v1/slack.ts
Outdated
| const isStableBranch = branchObject.aliasObject.isStableBranch; // bool or Falsey | ||
| aliases = aliases?.filter((a) => a); | ||
| if (!urlSlug && non_versioned == false) { | ||
| if (!urlSlug || urlSlug === '') { |
Contributor
There was a problem hiding this comment.
I don't think urlSlug === '' will ever evaluate - '' will be falsey here, so it should get caught by !urlSlug
it might be worth running a .trim() on urlSlug in case it's just whitespace here, and then explicitly asserting truthiness? Something like if (!urlSlug || !!urlSlug.trim())?
casthewiz
approved these changes
Mar 15, 2022
Contributor
casthewiz
left a comment
casthewiz
left a comment
There was a problem hiding this comment.
I think this is good from what I know about version handling and slug behavior - added a suggestion to catch a potential edge case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.