Skip to content

CLOUDP-96138: Add serverless to the atlas go client #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2021
Merged

CLOUDP-96138: Add serverless to the atlas go client #236

merged 3 commits into from
Jul 23, 2021

Conversation

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jul 23, 2021 •
edited
Loading

Description

Jira Ticket: CLOUDP-96138

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review July 23, 2021 12:30
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner July 23, 2021 12:30
@andreaangiolillo andreaangiolillo requested review from threebee and removed request for a team July 23, 2021 12:30
gssbzn
gssbzn reviewed Jul 23, 2021
View reviewed changes
@andreaangiolillo andreaangiolillo requested a review from gssbzn July 23, 2021 12:54
gssbzn
gssbzn reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I commented in the same thread probably got lost but...

I would also be in favour of maybe duplicating the create params with what you only need for create, it could be confusing for users to understand what params are dedicated clusters only and which ones are not, also it may be hard to maintain

@andreaangiolillo andreaangiolillo requested a review from gssbzn July 23, 2021 14:05
gssbzn
gssbzn approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the changes

@andreaangiolillo andreaangiolillo merged commit 34d12ee into master Jul 23, 2021
@gssbzn gssbzn deleted the CLOUDP-96138 branch September 14, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@threebee threebee Awaiting requested review from threebee

1 more reviewer

@gssbzn gssbzn gssbzn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreaangiolillo @gssbzn