Connection strings private #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderGo93
requested review from
PacoDw,
marinsalinas,
themantissa and
thetonymaster
shum
previously approved these changes
Apr 6, 2020
Collaborator
shum
left a comment
shum
left a comment
There was a problem hiding this comment.
Small string change, otherwise LGTM.
mongodbatlas/clusters_test.go
Outdated
Comment on lines
40
to
41
| "private": "mongodb://cluster0-shard-00-00-auylw.mongodb.net:27017,cluster0-shard-00-01-auylw.mongodb.net:27017,cluster0-shard-00-02-auylw.mongodb.net:27017/?ssl=true&authSource=admin&replicaSet=Cluster0-shard-0", | ||
| "privateSrv": "mongodb+srv://cluster0-auylw.mongodb.net" |
Collaborator
There was a problem hiding this comment.
Suggested change
| "private": "mongodb://cluster0-shard-00-00-auylw.mongodb.net:27017,cluster0-shard-00-01-auylw.mongodb.net:27017,cluster0-shard-00-02-auylw.mongodb.net:27017/?ssl=true&authSource=admin&replicaSet=Cluster0-shard-0", | |
| "privateSrv": "mongodb+srv://cluster0-auylw.mongodb.net" | |
| "private": "mongodb://cluster0-shard-00-00-pri.auylw.mongodb.net:27017,cluster0-shard-00-01-pri.auylw.mongodb.net:27017,cluster0-shard-00-02-pri.auylw.mongodb.net:27017/?ssl=true&authSource=admin&replicaSet=Cluster0-shard-0", | |
| "privateSrv": "mongodb+srv://cluster0-pri.auylw.mongodb.net" |
to keep it accurate. We should use this for all the other tests too.
Contributor
Author
There was a problem hiding this comment.
ok thank you, I'll change it, I copy pasted from standard because I couldn't find an example for this case in mongodb docs
Collaborator
There was a problem hiding this comment.
Yep, I realized that it wasn't in the docs either.
shum
approved these changes
Apr 6, 2020
PacoDw
approved these changes
Apr 6, 2020
Contributor
PacoDw
left a comment
PacoDw
left a comment
There was a problem hiding this comment.
LGTM! thank you so much 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added field
privateandprivateSrvfor connection strings