-
Notifications
You must be signed in to change notification settings - Fork 1.4k
mongo objectID for the relations #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marge with 2.2
marge with jenssegers/laravel-mongodb master
|
Can we get this implemented? Relationships should use MongoId. |
|
+1 it.. nice implementation.. |
|
Currently reviewing your PR. Will probably have to tag a new major version though. |
|
@jenssegers any update on this? |
|
@jenssegers, |
|
@rtler Could you please solve the conflicts? |
|
Any progress on this? Depending on this merge to do some things, can I help in any way? |
|
Well thing is, the new v3 release will bring support for the new mongodb PHP driver. I feel like doing both the driver and the mongo id's at the same time will break too many applications. Current plan is to release v3 soon with the new driver, and work on a v4 featuring the mongo id's. |
|
Also; because of the new mongodb driver, this PR is a bit outdated. So I can't really merge it into master. |
|
see #834 |
I make some changes to make this driver work with object id.
also, because some database still use mongoID as string for relations I add options to use objectID or not (default is not).