LG-5623 feat: add variant to GalleryIndicator component #3232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e90987 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +404 B (+0.03%) Total Size: 1.6 MB
ℹ️ View Unchanged
|
adamrasheed
requested review from
TheSonOfThomp and
Copilot
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
Add a variant prop to GalleryIndicator to support multiple visual styles and expose a Variant enum for consumers.
- Introduces a variant prop with a default value and wires it into indicator styling.
- Adds Variant const/type and exports it from the package.
- Updates styles and Storybook to support and showcase variants.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/gallery-indicator/src/index.ts | Re-exports GalleryIndicator and adds Variant to public API. |
| packages/gallery-indicator/src/GalleryIndicator/GalleryIndicator.types.ts | Adds variant prop, Variant const, and Variant type. |
| packages/gallery-indicator/src/GalleryIndicator/GalleryIndicator.tsx | Accepts variant with a default and passes it to styles. |
| packages/gallery-indicator/src/GalleryIndicator/GalleryIndicator.styles.ts | Implements variant-aware color mapping for base and active states. |
| packages/gallery-indicator/src/GalleryIndicator.stories.tsx | Adds controls and matrix combinations for variant. |
| .changeset/sad-apes-talk.md | Declares a minor version bump describing the new variant feature. |
packages/gallery-indicator/src/GalleryIndicator/GalleryIndicator.styles.ts
Show resolved
Hide resolved
packages/gallery-indicator/src/GalleryIndicator/GalleryIndicator.types.ts
Show resolved
Hide resolved
packages/gallery-indicator/src/GalleryIndicator/GalleryIndicator.styles.ts
Show resolved
Hide resolved
TheSonOfThomp
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Add GallyIndicator Color Variant
This PR adds a color variant to the
GalleryIndicatorcomponent✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes