LG-5777 chore(CI): NPM publish with OIDC #3369
Merged
+30
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
Author
|
Some major caveats with needing OIDC:
The alternative to OIDC
|
Contributor
|
Size Change: 0 B Total Size: 1.81 MB ℹ️ View Unchanged
|
Collaborator
Author
|
All 129 packages have been updated with a Trusted Publisher on npm |
TheSonOfThomp
requested review from
adamrasheed,
bruugey,
Copilot,
shaneeza and
stephl3
and removed request for
a team,
adamrasheed and
shaneeza
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI/CD pipeline to support NPM publishing with OpenID Connect (OIDC) authentication and upgrades the Node.js version from 18 to 22 across the repository.
Key Changes:
- Migrated NPM authentication from token-based to OIDC by adding required permissions and removing
.npmrcconfiguration steps - Upgraded Node.js version requirement from 18.20.8 to 22.21.0/22.21.1 across all environments
- Updated all GitHub Actions workflow files to use Node 22
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Updated minimum Node.js engine requirement to 22.21.0 |
.tool-versions |
Updated nodejs version to 22.21.1 for local development |
.github/workflows/release.yml |
Added OIDC permissions, removed NPM token configuration, updated to Node 22 |
.github/workflows/pr.yml |
Updated all Node.js setup steps to use version 22 |
.github/workflows/react17.yml |
Updated Node.js version to 22 in build and test jobs |
.github/workflows/sizeDiff.yml |
Updated Node.js version to 22 |
Contributor
|
Coverage after merging at/LG-5777-npm into main will be
Coverage Report for Changed Files
|
Collaborator
omg did you have to do this manually? :o |
stephl3
approved these changes
Dec 8, 2025
Comment on lines
-205
to
-209
| - name: Debug changesets output | ||
| run: | | ||
| echo "Changesets output: ${{ steps.changesets.outputs }}" | ||
| echo "Changesets output type: ${{ toJSON(steps.changesets.outputs) }}" | ||
| echo "--------------------------------" |
Collaborator
There was a problem hiding this comment.
oops should have dropped this, thank you!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
adamrasheed
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Updates all npm packages to use Trusted Publishers
Removes npm auth token from CI
Updates to node 22
🎟 Jira ticket: LG-5777