MONGOCRYPT-903 Case and diacritic sensitivity not honoured for explicit encryption#1158
Merged
mdb-ad merged 9 commits intomongodb:masterfrom May 6, 2026
Merged
MONGOCRYPT-903 Case and diacritic sensitivity not honoured for explicit encryption#1158mdb-ad merged 9 commits intomongodb:masterfrom
mdb-ad merged 9 commits intomongodb:masterfrom
Conversation
kevinAlbs
changed the title
kevinAlbs
reviewed
May 5, 2026
kevinAlbs
reviewed
May 6, 2026
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Also update the textopts.json used by the Python bindings tests to fix failing test-python tasks.
I can reproduce the failed test locally by building without ASan:
cmake -S. -Bcmake-build
cmake --build cmake-build --target mongocryptThen running:
export PYMONGOCRYPT_LIB=$(pwd)/cmake-build/libmongocrypt.dylib
pushd bindings/python
python -m pytest -v --ignore=test/performance .
popd
kevinAlbs
approved these changes
May 6, 2026
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with an added comment noting "f" means "folding".
kevinAlbs
requested review from
NoahStapp
and removed request for
NoahStapp and
connorsmacd
NoahStapp
approved these changes
May 6, 2026
Co-authored-by: Kevin Albertson <kevin.eric.albertson@gmail.com>
kevinAlbs
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial interpretation of the
casefanddiacfserver fields was backwards.