-
Notifications
You must be signed in to change notification settings - Fork 97
chore(NODE-3849)!: update dependencies and sync tooling #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| request.addResponse(buffer.slice(0, bytesNeeded)); | ||
| buffer.consume(bytesNeeded); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our read method will accomplish the same thing in one call, returning a new copy of the bytes and dropping them from the underlying bufferpool.
6a8bcf7 to
1b11893
Compare
1b11893 to
4cdfc8a
Compare
Co-authored-by: Anna Henningsen <anna@addaleax.net>
dariakp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions here
dariakp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe we should get at least one more person from the team to review before we merge
Description
What is changing?
This tooling sync and updates change brings:
There is no Bug fix:
stateMachine.js typo-ed(my mistake, it was correct)localhostWhat is the motivation for this change?
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>stateMachine.js:239