VS-146: Support Fully Qualified Names for Data Models #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
requested changes
Jul 2, 2024
| Builders<Person>.Filter.Eq(p => p.Name, MongoDB.Analyzer.Tests.Common.DataModel.StaticHolder.ReadonlyString) | | ||
| Builders<Person>.Filter.Eq(p => p.Name, MongoDB.Analyzer.Tests.Common.DataModel.StaticHolder.ReadonlyString2) | | ||
| Builders<Person>.Filter.Eq(p => p.Name, MongoDB.Analyzer.Tests.Common.DataModel.StaticHolder.ReadonlyString) | | ||
| Builders<Person>.Filter.Eq(p => p.Vehicle.VehicleType.Type, MongoDB.Analyzer.Tests.Common.DataModel.StaticHolder.ReadonlyEnum) | |
Collaborator
There was a problem hiding this comment.
Same naming pattern, no need to test all types.
Also consider combing Qualified_inside_method and Qualified_inside_namespace into single test with different naming nesting levels. Given A.B...X.Y.Class.Property is a full name, let's test:
A.B...X.Y.Class.Propert
B...X.Y.Class.Propert
X.Y.Class.Propert
Y.Class.Propert
Same for Builders<A.B...X.Y.Class>.
Also test cases like:
using user = MongoDB.Analyzer.Tests.Common.DataModel.User;
using driver = MongoDB.Driver;
_ = driver.Builders<user>.Filter.Eq(user => user.Age, 22);
_ = driver.Builders<MongoDB.Analyzer.Tests.Common.DataModel.User>.Filter.Eq(user => user.Age, 22);
BorisDog
reviewed
Jul 2, 2024
| var isBuildersContainer = false; | ||
| var containsAlias = false; | ||
|
|
||
| //Check if Member Expression is Builders Container |
Collaborator
There was a problem hiding this comment.
Please add space after // in all comments
| syntaxNode = (syntaxNode as MemberAccessExpressionSyntax)?.Expression; | ||
| } | ||
|
|
||
| //Skip Nodes that are Builder Containers and that don't contain alias |
Collaborator
There was a problem hiding this comment.
Add two examples in the comment:
// For example MongoDB.Driver.Builders, driverAlias.Builders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Fully Qualified Names for Data Models