Small corrections

Author: papafe

src/MongoDB.Bson/Serialization/IBsonSerializerExtensions.cs

@@ -70,7 +70,7 @@ serializer is IHasDiscriminatorConvention hasDiscriminatorConvention
         /// <param name="shouldReconfigure">
         /// An optional predicate to determine if the reconfiguration should be applied to the current serializer.
         /// </param>
-        /// <typeparam name="T">The specific type of serializer to be reconfigured.</typeparam>
+        /// <typeparam name="T">The input type for the reconfigure method.</typeparam>
         /// <returns>
         /// The reconfigured serializer, or <c>null</c> if no leaf serializer could be reconfigured.
         /// </returns>

src/MongoDB.Bson/Serialization/Serializers/DateOnlySerializer.cs

@@ -117,15 +117,13 @@ public DateOnlySerializer(BsonType representation, DateOnlyDocumentFormat docume
         public override DateOnly Deserialize(BsonDeserializationContext context, BsonDeserializationArgs args)
         {
             var bsonReader = context.Reader;
-            DateOnly value;
 
             var bsonType = bsonReader.GetCurrentBsonType();
 
             switch (bsonType)
             {
                 case BsonType.DateTime:
-                    value = VerifyAndMakeDateOnly(BsonUtils.ToDateTimeFromMillisecondsSinceEpoch(bsonReader.ReadDateTime()));
-                    break;
+                    return VerifyAndMakeDateOnly(BsonUtils.ToDateTimeFromMillisecondsSinceEpoch(bsonReader.ReadDateTime()));
 
                 case BsonType.Document:
                     var ticks = 0L;
@@ -153,30 +151,24 @@ public override DateOnly Deserialize(BsonDeserializationContext context, BsonDes
                     };
 
                 case BsonType.Decimal128:
-                    value = VerifyAndMakeDateOnly(new DateTime(_converter.ToInt64(bsonReader.ReadDecimal128()), DateTimeKind.Utc));
-                    break;
+                    return VerifyAndMakeDateOnly(new DateTime(_converter.ToInt64(bsonReader.ReadDecimal128()), DateTimeKind.Utc));
 
                 case BsonType.Double:
-                    value = VerifyAndMakeDateOnly(new DateTime(_converter.ToInt64(bsonReader.ReadDouble()), DateTimeKind.Utc));
-                    break;
+                    return VerifyAndMakeDateOnly(new DateTime(_converter.ToInt64(bsonReader.ReadDouble()), DateTimeKind.Utc));
 
                 case BsonType.Int32:
-                    value = VerifyAndMakeDateOnly(new DateTime(bsonReader.ReadInt32(), DateTimeKind.Utc));
-                    break;
+                    return VerifyAndMakeDateOnly(new DateTime(bsonReader.ReadInt32(), DateTimeKind.Utc));
 
                 case BsonType.Int64:
-                    value = VerifyAndMakeDateOnly(new DateTime(bsonReader.ReadInt64(), DateTimeKind.Utc));
-                    break;
+                    return VerifyAndMakeDateOnly(new DateTime(bsonReader.ReadInt64(), DateTimeKind.Utc));
 
                 case BsonType.String:
-                    value = DateOnly.ParseExact(bsonReader.ReadString(), "yyyy-MM-dd");
-                    break;
+                    return DateOnly.ParseExact(bsonReader.ReadString(), "yyyy-MM-dd");
 
                 default:
                     throw CreateCannotDeserializeFromBsonTypeException(bsonType);
             }
 
-            return value;
 
             DateOnly VerifyAndMakeDateOnly(DateTime dt)
             {

tests/MongoDB.Bson.Tests/Serialization/Serializers/DateOnlySerializerTests.cs

@@ -232,17 +232,28 @@ public void Equals_with_equal_fields_should_return_true()
         }
 
         [Theory]
-        [InlineData(BsonType.String)]
-        [InlineData(BsonType.Int64)]
-        [InlineData(BsonType.Document)]
-        public void Equals_with_not_equal_fields_should_return_true(BsonType representation)
+        [ParameterAttributeData]
+        public void Equals_with_different_representation_and_format_should_return_correct(
+            [Values(BsonType.DateTime, BsonType.String, BsonType.Int64, BsonType.Document)]
+            BsonType representation,
+            [Values(DateOnlyDocumentFormat.DateTimeTicks, DateOnlyDocumentFormat.YearMonthDay)]
+            DateOnlyDocumentFormat format)
         {
             var x = new DateOnlySerializer();
-            var y = new DateOnlySerializer(representation);
+            var y = new DateOnlySerializer(representation, format);
 
             var result = x.Equals(y);
+            var result2 = y.Equals(x);
+            result.Should().Be(result2);
 
-            result.Should().Be(false);
+            if (representation == BsonType.DateTime && format == DateOnlyDocumentFormat.DateTimeTicks)
+            {
+                result.Should().Be(true);
+            }
+            else
+            {
+                result.Should().Be(false);
+            }
         }
 
         [Fact]