CSHARP-3840: Unresponsive/deadlocked cluster.Dispose() #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
force-pushed
the
csharp3840
branch
from
68fa96d to
c240e1c
Compare
sanych-sun
requested review from
BorisDog
and removed request for
JamesKovacs
BorisDog
requested changes
Dec 16, 2024
| throw new TimeoutException(message); | ||
| } | ||
| if (state == 4) { throw new OperationCanceledException(); } | ||
| WaitHandle.WaitAny(new[] { connectOperation.AsyncWaitHandle, cancellationToken.WaitHandle }, _settings.ConnectTimeout); |
Contributor
There was a problem hiding this comment.
nit: [connectOperation.AsyncWaitHandle, cancellationToken.WaitHandle]
| if (endPoint is DnsEndPoint dnsEndPoint) | ||
| { | ||
| // mono doesn't support DnsEndPoint in its BeginConnect method. | ||
| connectTask = Task.Factory.FromAsync(socket.BeginConnect(dnsEndPoint.Host, dnsEndPoint.Port, null, null), socket.EndConnect); |
Contributor
There was a problem hiding this comment.
Please check if ConnectAsync can replace BeginConnect (SocketTaskExtensions)
BorisDog
requested changes
Dec 20, 2024
|
|
||
| if (!connectOperation.IsCompleted) | ||
| { | ||
| socket.Dispose(); |
Contributor
There was a problem hiding this comment.
I think we need to hide Dispose exceptions here, and probably in all cases?
| { | ||
| // a timeout or operation cancelled exception will be thrown instead | ||
| } | ||
| socket.Dispose(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.