Reduction of reflection calls --> minor deserialization performance gain #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnickless
changed the title
dnickless
force-pushed
the
BsonClassMapSerializer_Reduce_Reflection
branch
from
aee05d8 to
35545b2
Compare
…gh reflection for every Deserialize call
dnickless
force-pushed
the
BsonClassMapSerializer_Reduce_Reflection
branch
from
35545b2 to
b5caef6
Compare
Contributor
|
Thanks @dnickless for your contribution. This file has changed a few times since this PR, and this fix is not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some reflection code in the
Deserializemethod which would get called repeatedly. But since the ClassMap is frozen (gets checked in the constructor) it should be sufficient to execute this code once upon construction of theBsonClassMapSerializerand then use the cached value.