CSHARP-3355: Add more spec tests for invalid relaxed UUIDs. #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
requested changes
Feb 5, 2021
rstam
requested changes
Feb 5, 2021
src/MongoDB.Bson/IO/JsonReader.cs
Outdated
| { | ||
| throw new FormatException($"Invalid $uuid hyphens format: '{uuidTokenStringValue}'."); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think you can replace lines 2093-2112 with:
var guid = Guid.Parse(uuidToken.StringValue);
var binaryData = new BsonBinaryData(guid, GuidRepresentation.Standard);
Guid.Parse already does all the validations we need.
There was a problem hiding this comment.
good point, done
|
Removed James since Robert picked it up. |
JamesKovacs
requested changes
Feb 13, 2021
src/MongoDB.Bson/IO/JsonReader.cs
Outdated
| using System.Globalization; | ||
| using System.IO; | ||
| using System.Text.RegularExpressions; | ||
| using System.Linq; |
DmitryLukyanov
force-pushed
the
csharp3355
branch
from
cb5295b to
636be2f
Compare
DmitryLukyanov
force-pushed
the
csharp3355
branch
from
636be2f to
2c0e72b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EG: https://evergreen.mongodb.com/version/601d956b3e8e86586c978855