Add support for delete and update operations without filters #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/integrationTest/java/com/mongodb/hibernate/query/mutation/UpdatingIntegrationTests.java
vbabanin
changed the title
vbabanin
commented
Oct 17, 2025
| } | ||
|
|
||
| private AstFilter getKeyFilter(AbstractRestrictedTableMutation<? extends MutationOperation> tableMutation) { | ||
| private AstFilter createKeyFilter(AbstractRestrictedTableMutation<? extends MutationOperation> tableMutation) { |
Member
Author
There was a problem hiding this comment.
We have several helper methods for creating Mongo AST elements:
getAstComparisonFilterOperator, getKeyFilter, createMatchStage, createSortStage, createProjectStage, createAstSortField.
Their naming pattern is inconsistent - some use get, others create.
To make them consistent and clearer in intent, we could use a common prefix, and create i think better reflects their behavior.
This PR also adds createAstFilter following that convention.
HIBERNATE-130
stIncMale
requested changes
Oct 20, 2025
src/main/java/com/mongodb/hibernate/internal/translate/mongoast/filter/AstEmptyFilter.java
Outdated
Show resolved
Hide resolved
src/test/java/com/mongodb/hibernate/internal/translate/mongoast/filter/AstEmptyFilterTest.java
Show resolved
Hide resolved
src/main/java/com/mongodb/hibernate/internal/translate/AbstractMqlTranslator.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/com/mongodb/hibernate/query/AbstractQueryIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/com/mongodb/hibernate/query/mutation/UpdatingIntegrationTests.java
Outdated
Show resolved
Hide resolved
…tMqlTranslator.java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
stIncMale
reviewed
Oct 22, 2025
src/test/java/com/mongodb/hibernate/internal/translate/mongoast/filter/AstEmptyFilterTest.java
Outdated
Show resolved
Hide resolved
…t/filter/AstEmptyFilterTest.java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
stIncMale
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIBERNATE-130