Skip to content

Use FeatureNotSupportedException instead of RuntimeException where appropriate #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

Use FeatureNotSupportedException instead of RuntimeException where appropriate #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/com/mongodb/hibernate/jdbc/DatabaseMetaDataAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.mongodb.hibernate.jdbc;

import com.mongodb.hibernate.internal.FeatureNotSupportedException;
import java.sql.Connection;
import java.sql.DatabaseMetaData;
import java.sql.ResultSet;
Expand Down Expand Up @@ -102,12 +103,12 @@ default String getDriverVersion() throws SQLException {

@Override
default int getDriverMajorVersion() {
throw new RuntimeException("getDriverMajorVersion not implemented");
throw new FeatureNotSupportedException("getDriverMajorVersion not implemented");
}

@Override
default int getDriverMinorVersion() {
throw new RuntimeException("getDriverMinorVersion not implemented");
throw new FeatureNotSupportedException("getDriverMinorVersion not implemented");
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ private static boolean isExcludeProjectSpecification(Map.Entry<String, BsonValue
var exclude = (value.isBoolean() && !value.asBoolean().getValue())
|| (value.isNumber() && value.asNumber().intValue() == 0);
if (exclude && !key.equals(ID_FIELD_NAME)) {
throw new RuntimeException(format(
throw new FeatureNotSupportedException(format(
"Exclusions are not allowed in `$project` specifications, except for the [%s] field: [%s, %s]",
ID_FIELD_NAME, key, value));
}
Expand Down