implement java.sql.DatabaseMetaData #22

NathanQingyangXu · 2024-12-06T02:54:12Z

https://jira.mongodb.org/browse/HIBERNATE-37

Most of the java.sql.DatabaseMetaData used by Hibernate is irrelevant to Mongo Dialect (vast majority is for DDL processing, which has no counterpart in Mongo Dialect; the only DDL in Mongo Dialect is for index and unique constraint creation in the last milestone), except for the following items:

mongodb version (if below 6.0, MongoDialect will complain by throwing exception)
boolean supportsBatchUpdates(), which is vital to MongoDB Dialect

The mongoDB version might be used for future version-specific feature exploitation (e.g. new bulk write feature introduced since v8).

The current implementation is based on running buildinfo command to admin database.

Finally we could get rid of the deprecated default constructor of MongoDialect.

…rnal `admin` database access is required to get metadata

stIncMale

The last reviewed commit is c5f397f. I did not review ResultSetAdapter, as I am not yet sure if it's actually needed in this PR.

src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java

src/test/resources/logback-test.xml

src/test/java/com/mongodb/hibernate/jdbc/MongoConnectionTests.java

src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java

src/test/java/com/mongodb/hibernate/jdbc/MongoConnectionTests.java

…ngoStatement and MongoDatabaseMetaData

…R and update Javadoc consistently

…irrelevant to our need

…val won't trigger integration testing failure)

….java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>

…` logger from test to integrationTest

…tement

…ticket (which will enlarge scope to provide the Driver versions)

src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java

stIncMale

The last reviewed commit is d3cc51d.

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java

jyemin

I don't plan to review this further so LGTM-ing to allow merge when Valentin approves.

# Conflicts: # src/test/java/com/mongodb/hibernate/jdbc/MongoClientCustomizerTests.java

Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java # src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java # src/test/java/com/mongodb/hibernate/jdbc/MongoConnectionTests.java

…RNATE-37-metadata

stIncMale

The last reviewed commit is a3ae083.

stIncMale · 2025-01-28T03:03:17Z

src/test/resources/hibernate.properties

 jakarta.persistence.jdbc.url=mongodb://localhost/mongo-hibernate-test?directConnection=false
 hibernate.dialect=com.mongodb.hibernate.dialect.MongoDialect
 hibernate.connection.provider_class=com.mongodb.hibernate.jdbc.MongoConnectionProvider
+hibernate.boot.allow_jdbc_metadata_access=false


Nice! This way all unit tests will avoid trying to load the metadata. This is better than having to specify JdbcSettings.ALLOW_METADATA_ON_BOOT for each of them.

yeah, separating unit and integration testings make lots of sense for they have different requirements and specialities. In the future we might introduce Hibernate's integration testing library (hibernate-testing) which only makes sense in integration testing context.

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java

stIncMale

The last reviewed commit is b229a4d.

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java

stIncMale

The last reviewed commit is e74ee15.

NathanQingyangXu requested review from jyemin and stIncMale December 6, 2024 02:54

NathanQingyangXu force-pushed the HIBERNATE-37-metadata branch 4 times, most recently from 15c948c to aa09c03 Compare December 19, 2024 15:08

NathanQingyangXu force-pushed the HIBERNATE-37-metadata branch 2 times, most recently from 515e261 to 5d3a0dd Compare January 16, 2025 15:53

implement java.sql.DatabaseMetaData

a36efb9

NathanQingyangXu force-pushed the HIBERNATE-37-metadata branch from 5d3a0dd to a36efb9 Compare January 16, 2025 16:40

NathanQingyangXu added 2 commits January 16, 2025 12:58

move SessionFactoryTests and SessionTests to integrationTest for exte…

798bc32

…rnal `admin` database access is required to get metadata

remove use of confusing NotYetImplementedSQLException.java

c5f397f

stIncMale requested changes Jan 22, 2025

View reviewed changes

NathanQingyangXu and others added 14 commits January 23, 2025 10:00

remove overlooked isWrapperFor method from MongoConnection

93f1955

add missing checkClosed() in MongoConnection#getMetaData

d7a8a47

add usage of ClientSession during getting metadata by runCommand()

a8aab83

remove outdated javadoc for MongoDialect's only constructor

edf353c

make unwrap() and isWrapperFor() consistent among MongoConnection, Mo…

5c34d72

…ngoStatement and MongoDatabaseMetaData

change DatabaseMetaDataAdapter to interface as in PreparedStatement P…

2b78ae2

…R and update Javadoc consistently

remove ResultSetAdapter usage for they are only used in DDL which is …

209866e

…irrelevant to our need

remove irrelevant methods from MongoDatabaseMetaData (as long as remo…

8243793

…val won't trigger integration testing failure)

Update src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData…

9ccc014

….java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>

move `org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator…

cc43b25

…` logger from test to integrationTest

fix erroneous structures in MongoConnectionTests

1fef9fe

add error level logging to MongoConnection#getMetaData()

599b0d6

remove JDBC markers from DatabaseMetaDataAdapter

d971518

add ClosedTest to MongoConnectionTests to be consistent with MongoSta…

cd9517c

…tement

NathanQingyangXu requested a review from stIncMale January 23, 2025 21:20

add code comments to MongoDatabaseMetaData to refer to other related …

d3cc51d

…ticket (which will enlarge scope to provide the Driver versions)

stIncMale mentioned this pull request Jan 23, 2025

implement java.sql.PreparedStatement #24

Merged

stIncMale reviewed Jan 24, 2025

View reviewed changes

src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java Outdated Show resolved Hide resolved

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java Outdated Show resolved Hide resolved

stIncMale requested changes Jan 24, 2025

View reviewed changes

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java Outdated Show resolved Hide resolved

jyemin previously approved these changes Jan 24, 2025

View reviewed changes

NathanQingyangXu added 2 commits January 27, 2025 15:20

Merge branch 'main' into HIBERNATE-37-metadata

d439150

# Conflicts: # src/test/java/com/mongodb/hibernate/jdbc/MongoClientCustomizerTests.java

disable metadata access to make MongoConnectionProviderTests pass

c25590d

NathanQingyangXu dismissed jyemin’s stale review via c25590d January 27, 2025 20:28

NathanQingyangXu and others added 4 commits January 27, 2025 15:33

remove duplicated closed testing cases in MongoConnectionTests

70a180f

remove transaction isolation level testing in MongoConnectionTests

a837790

add driver version pair parsing logic and testing case

aa9d824

Update src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java

c0cdb97

Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>

NathanQingyangXu requested a review from stIncMale January 27, 2025 21:32

NathanQingyangXu added 3 commits January 27, 2025 16:43

Merge branch 'main' into HIBERNATE-37-metadata

18b45ad

# Conflicts: # src/main/java/com/mongodb/hibernate/jdbc/MongoConnection.java # src/main/java/com/mongodb/hibernate/jdbc/MongoStatement.java # src/test/java/com/mongodb/hibernate/jdbc/MongoConnectionTests.java

fix some broken unit testing case after mering in main branch

d1f476d

Merge remote-tracking branch 'origin/HIBERNATE-37-metadata' into HIBE…

a3ae083

…RNATE-37-metadata

stIncMale requested changes Jan 28, 2025

View reviewed changes

improve version logic as per code review comments

ed20a6c

NathanQingyangXu requested a review from stIncMale January 28, 2025 14:59

Merge branch 'mongodb:main' into HIBERNATE-37-metadata

b229a4d

stIncMale requested changes Jan 28, 2025

View reviewed changes

src/main/java/com/mongodb/hibernate/jdbc/MongoDatabaseMetaData.java Outdated Show resolved Hide resolved

fix erroneous code change to Version#parse(String) in last commit

e74ee15

stIncMale approved these changes Jan 28, 2025

View reviewed changes

NathanQingyangXu merged commit 6ec0093 into mongodb:main Jan 28, 2025
6 checks passed

NathanQingyangXu deleted the HIBERNATE-37-metadata branch January 28, 2025 20:53

implement java.sql.DatabaseMetaData #22

implement java.sql.DatabaseMetaData #22

Uh oh!

Conversation

NathanQingyangXu commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jyemin left a comment

Choose a reason for hiding this comment

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

stIncMale Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

NathanQingyangXu Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stIncMale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NathanQingyangXu commented Dec 6, 2024 •

edited

Loading