Split out TypeMqlValuesFunctionalTest.asString tests for nested objects #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New features have arrived in 8.2 JAVA-5960
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR splits test cases for the asString method to handle the introduction of new features in MongoDB 8.2. The change separates tests for nested objects (arrays and documents) that previously threw exceptions but are now supported in version 8.2.
- Removes version assumption from main
asStringTestmethod - Creates separate test methods for pre-8.2 and 8.2+ behavior with nested objects
- Updates expected behavior for nested object string conversion in 8.2+
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nhachicha
reviewed
Sep 24, 2025
driver-core/src/test/functional/com/mongodb/client/model/mql/TypeMqlValuesFunctionalTest.java
Show resolved
Hide resolved
nhachicha
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features have arrived in 8.2
JAVA-5960