Use ZstdInputStreamNoFinalizer for Zstd decompression#1924
Merged
rozza merged 3 commits intomongodb:mainfrom Mar 26, 2026
Merged
Use ZstdInputStreamNoFinalizer for Zstd decompression#1924rozza merged 3 commits intomongodb:mainfrom
rozza merged 3 commits intomongodb:mainfrom
Conversation
Replace ZstdInputStream with ZstdInputStreamNoFinalizer to avoid deprecated Java finalization (JEP 421) and reduce GC overhead. The driver already closes the stream via try-with-resources, so the finalizer safety net is unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Note this PR was fully automated vi claude code using my jira-work skill. Then manually reviewed by myself. |
Member
Author
|
Note: Note: The ZstdInputStream uses ZstdInputStreamNoFinalizer internally. See: https://github.com/luben/zstd-jni/blob/master/src/main/java/com/github/luben/zstd/ZstdInputStream.java - so this updates to just use the actual implementation. |
nhachicha
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ZstdInputStream with ZstdInputStreamNoFinalizer to avoid deprecated Java finalization (JEP 421) and reduce GC overhead. The driver already closes the stream via try-with-resources, so the finalizer safety net is unnecessary.
JAVA-6137