Skip QE prefixPreview and suffixPreview tests on server 9.0.0+#1954
Merged
nhachicha merged 2 commits intomongodb:mainfrom Apr 30, 2026
Merged
Skip QE prefixPreview and suffixPreview tests on server 9.0.0+#1954nhachicha merged 2 commits intomongodb:mainfrom
nhachicha merged 2 commits intomongodb:mainfrom
Conversation
Update specifications submodule to pick up maxServerVersion guards for unified spec tests. Skip all text explicit encryption prose tests on server 9.0+ since prefixPreview/suffixPreview are deprecated. JAVA-6184
rozza
requested review from
nhachicha and
strogiyotec
and removed request for
strogiyotec
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Java driver’s functional test suite to accommodate server 9.0+ behavior changes around Queryable Encryption (QE) text explicit encryption, and adds a temporary unified-test skip for a failing change streams spec test.
Changes:
- Skip all text explicit encryption prose tests when running against server version 9.0+.
- Add a temporary
skipJiraguard for a failingchange-streams-nsTypeunified spec test (JAVA-6181).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java |
Adds a temporary unified-spec skip for a change-streams nsType test. |
driver-sync/src/test/functional/com/mongodb/client/AbstractClientEncryptionTextExplicitEncryptionTest.java |
Skips the QE text explicit encryption prose tests on server 9.0+. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Missed a prose test in the sync driver - temp disabled |
nhachicha
reviewed
Apr 30, 2026
| assumeTrue("Requires newer MongoCrypt version", getMongoCryptVersion().compareTo(REQUIRED_LIB_MONGOCRYPT_VERSION) >= 0); | ||
| assumeTrue(serverVersionAtLeast(8, 2)); | ||
| // TODO-JAVA-6168 update prose tests for post 9.0 | ||
| assumeTrue(!serverVersionAtLeast(9, 0)); |
Collaborator
There was a problem hiding this comment.
Claude Nit - we can use assumeFalse instead
nhachicha
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update specifications submodule to pick up maxServerVersion guards for unified spec tests. Skip all text explicit encryption prose tests on server 9.0+ since prefixPreview/suffixPreview are deprecated.
JAVA-6184