Do small improvements related to value-based classes#1964
Merged
stIncMale merged 1 commit intomongodb:mainfrom May 7, 2026
Merged
Do small improvements related to value-based classes#1964stIncMale merged 1 commit intomongodb:mainfrom
stIncMale merged 1 commit intomongodb:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small internal refinements related to “value-based” classes by tightening test visibility in TimePoint and simplifying AttachmentKey instantiation via a factory method.
Changes:
- Annotate
TimePoint’s constructor as@VisibleForTesting(otherwise = PRIVATE)to clarify intended access outside tests. - Replace direct
new DefaultAttachmentKey<>(...)construction with aDefaultAttachmentKey.of(...)factory. - Add a “value-based” class Javadoc note to
DefaultAttachmentKey.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| driver-core/src/main/com/mongodb/internal/time/TimePoint.java | Marks constructor as visible-for-testing to better document intended encapsulation. |
| driver-core/src/main/com/mongodb/internal/operation/retry/AttachmentKeys.java | Introduces a factory method for DefaultAttachmentKey and adds value-based documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stIncMale
force-pushed
the
smallValueBasedImprovements
branch
from
332f5ab to
6149c85
Compare
vbabanin
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.