GridFS download test reenablement#1991
Open
rozza wants to merge 3 commits into
Open
Conversation
- Remove JAVA-5839 skip entry for "timeoutMS applied to entire download, not individual parts" test so it runs in CI JAVA-5839
Rename dir/file/test to directory/fileDescription/testDescription to clarify that 'file' refers to the spec file's description field, not the filename, and 'test' refers to the individual test description. JAVA-5839
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables the unified spec test covering CSOT behavior for GridFS downloads (JAVA-5839) by replacing a hard skip with a targeted test-data transformation, and clarifies naming in the unified test modification helpers.
Changes:
- Removed the JAVA-5839 skip for the GridFS download CSOT spec test and replaced it with a transformation that relaxes timeouts to reduce CI flakiness.
- Renamed
dir/file/testidentifiers inUnifiedTestModificationstodirectory/fileDescription/testDescriptionfor clarity and consistency with spec terminology. - Added a transformation mechanism (
TestTransformer) and integrated it into the unified test runner setup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTestModifications.java | Adds test-data transformation support, renames identifiers for clarity, and applies a transformation for the GridFS CSOT test. |
| driver-sync/src/test/functional/com/mongodb/client/unified/UnifiedTest.java | Applies registered transformations during test setup before entity initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ation Add TestTransformer functional interface and transform() method to TestDef, allowing spec test data (entities and definition) to be mutated before execution. Transformations are logged with a mandatory reason string. Apply transform for JAVA-5839: bump timeoutMS from 75 to 250 and blockTimeMS from 50 to 200 for the GridFS download timeout test to avoid CI latency failures. The 150ms margin (6x the original 25ms) should be reliable across CI environments. JAVA-5839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes in 3 parts:
JAVA-5839