JAVA-2715: Query builder for new lookup stage #434
Conversation
|
You’re welcome! 😉 |
Fixed CS issues
| */ | ||
| public class Variable<TExpression> { | ||
| private final String name; | ||
| private TExpression value; |
| * @since 3.7 | ||
| * | ||
| */ | ||
| public static Bson lookup(final String from, final List<? extends Bson> pipeline, final String as) { |
There was a problem hiding this comment.
I'd like to see a unit and functional test for this overload. Currently it's untested, but I want to make sure we catch any issues when let is null.
| } | ||
|
|
||
| /** | ||
| * Creates a $lookup pipeline stage for the specified filter |
There was a problem hiding this comment.
Let's fix this comment now, as there is no filter, but rather a pipeline. Perhaps:
Creates a $lookup pipeline stage, joining the current collection with the one specified in from using the given pipeline.
There was a problem hiding this comment.
(I realize the comment in the existing lookup method is misleading as well. Feel free to fix that one too if you're so inclined.)
| * Creates a $lookup pipeline stage for the specified filter | ||
| * | ||
| * @param from the name of the collection in the same database to perform the join with. | ||
| * @param let specifies variables to use in the pipeline field stages. |
There was a problem hiding this comment.
Replace "specifies" with "the".
|
It's hard for me to know what's wrong because it works on my pc :
|
| ) | ||
|
|
||
| collection.insertDocuments( | ||
| Document.parse('''{ "_id" : 1, "student" : "Ann Aardvark", |
There was a problem hiding this comment.
The build failure is due to trailing whitespace on this line. If you run `./gradlew driver-core:check' it should fail for you too.
|
Thanks for the work on this @fhassak! It's now merged to master. |
JAVA-2715: Support lookup stage in Aggregates builder
3 participants
thanks to @csarrazi who helped me for this contribution