3.8.x continuous matrix testing #653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an integration test that asserts an exception is thrown when a change stream projects out the _id field. Running against 3.6 and 4.0, this condition is checked in the driver itself while processing the results. But in 4.4 the server started replying with an error on the getMore in this scenario. A newer driver would know not to retry in this case, because newer drivers implemented an allow list for resumeable change stream errors when the server version. But older drivers don't have that logic, so it will treat this command error as retryable and never actually report the error. JAVA-3942
The reply format has changed in a way that breaks the test. This test has been disabled in subsequent releases and ultimately just removed. JAVA-3942
Change the test so that it produces a non-zero score so that the score won't be excluded by later server versions. JAVA-3942
JAVA-3942
JAVA-3942
JAVA-3942
JAVA-3942
jyemin
commented
Jan 29, 2021
| - command: attach.xunit_results | ||
| params: | ||
| file: ./src/*/build/test-results/TEST-*.xml | ||
| file: ./src/*/build/test-results/test/TEST-*.xml |
There was a problem hiding this comment.
Test uploading was actually broken in the 3.x branch, so I just fixed it.
| ${PREPARE_SHELL} | ||
| echo '{"results": [{ "status": "FAIL", "test_file": "Build", "log_raw": "No test-results.json found was created" } ]}' > ${PROJECT_DIRECTORY}/test-results.json | ||
| "install dependencies": |
There was a problem hiding this comment.
The presence of this function caused evergreen to refuse to load the file, so had to remove it.
| } | ||
|
|
||
| private static int getInputCount(final BsonDocument result) { | ||
| return result.getDocument("counts").getNumber("input").intValue(); |
There was a problem hiding this comment.
These changes are to prevent the driver from failing when no statistics are present in the reply. Without this change, we can't run mapReduce operations at all.
| BsonDocument outputDocument = new BsonDocument(getAction(), new BsonString(getCollectionName())); | ||
| outputDocument.append("sharded", BsonBoolean.valueOf(isSharded())); | ||
| outputDocument.append("nonAtomic", BsonBoolean.valueOf(isNonAtomic())); | ||
| if (description != null && !serverIsAtLeastVersionFourDotFour(description)) { |
There was a problem hiding this comment.
Without this change, the server will fail to execute the operation
rozza
requested changes
Feb 1, 2021
| ${PREPARE_SHELL} | ||
| echo '{"results": [{ "status": "FAIL", "test_file": "Build", "log_raw": "No test-results.json found was created" } ]}' > ${PROJECT_DIRECTORY}/test-results.json | ||
| "install dependencies": |
| } | ||
|
|
||
| private static int getInputCount(final BsonDocument result) { | ||
| return result.getDocument("counts").getNumber("input").intValue(); |
driver-core/src/main/com/mongodb/operation/MapReduceToCollectionOperation.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch to the 3.8.x branch to fulfill the goals for continuous matrix testing for the 4.0-era driver, which was 3.8.0. Similar PRs will be done for the 4.2 and 4.4 era release branches. What I've done here is two things:
There's nothing really new here. All these changes have been applied already in one form or another to the master branch of the driver. It was just a matter of finding them and copying them to this branch.
JAVA-3942
Full patch build: https://spruce.mongodb.com/version/60133b4d9ccd4e019373ad0d/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC