-
Notifications
You must be signed in to change notification settings - Fork 1.5k
JAVA-3684: deprecate geohaystack #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one thing, where methods are deprecated you should also add the @deprecated
tag and message in the java docs
I thought I had added the |
@terakilobyte - here's an example: mongo-java-driver/driver-core/src/main/com/mongodb/event/ConnectionPoolListener.java Lines 133 to 138 in 8574c6d
|
I've added to the method docs for the public facing methods. I was unsure if it needed to be done for the methods in internal based on driver policy. |
@terakilobyte unfortunately you have to double annotate with Java once for thing being deprecated and then again in the javadoc. Scala is nicer as the annotation is combined. I've updated the java docs and will squash and merge. Many thanks |
geoHaystack was deprecated in MongoDB 4.4
This reverts commit 8e0ea26.
This removes mention of geoHaystack from the docs and marks methods as deprecated.