JAVA-378 reallocate buffer when changing chunksize of GridFsInputFile #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GridFSInputFile
|
Hey... thanks for the patch. Do you think we should also change the setChunkSize method so that it throws and exception if the following is true? |
nzrgit
pushed a commit
that referenced
this pull request
May 12, 2012
JAVA-378 reallocate buffer when changing chunksize of GridFsInputFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests relates to an issue reported 47 weeks ago.
If you change the chunksize of an GridFsInputFile to a size greater than the default you will get an IndexOutOfBounds Exception, because the buffer isn't reallocated to fit the size.
BR lesnail