PHPC-1645: Allow disabling of libmongoc client persistence #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
phpc-1645
branch
2 times, most recently
from
8289f59 to
891fdbe
Compare
jmikola
changed the title
Member
Author
|
@alcaeus this is now ready for a thorough review. |
alcaeus
approved these changes
Jan 11, 2021
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
LGTM apart from the one nit. I appreciate the diligence of duplicating regression tests to ensure they don't break with disabled client persistence 👍
Co-authored-by: Andreas Braun <alcaeus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1645
This supersedes #1165.