PHPC-1975: Disable SKIPIF caching for skip_if_not_clean on PHP 8.1 #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Sep 22, 2021
Member
alcaeus
left a comment
alcaeus
left a comment
There was a problem hiding this comment.
LGTM - wording can stay if you don't like the alternative.
tests/utils/skipif.php
Outdated
Member
There was a problem hiding this comment.
Nit: this suggests that this method skips tests if there's no cache. disable_skipif_caching seems more appropriate, but I defer to your judgment.
Member
Author
There was a problem hiding this comment.
That thought did occur to me when writing this. I agree that disable_skipif_caching is a much better name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1975