Skip to content

PHPC-2101: Default Binary constructor parameter to TYPE_GENERIC #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

PHPC-2101: Default Binary constructor parameter to TYPE_GENERIC #1359

wants to merge 0 commits into from

Conversation

@levon80999
Copy link
Contributor

@levon80999 levon80999 commented Sep 8, 2022 •
edited
Loading

@levon80999 levon80999 changed the title PHPC-2101: Default Binary constructor parameter to TYPE_GENERIC !DRAFT! PHPC-2101: Default Binary constructor parameter to TYPE_GENERIC Sep 8, 2022
@levon80999 levon80999 changed the title !DRAFT! PHPC-2101: Default Binary constructor parameter to TYPE_GENERIC PHPC-2101: Default Binary constructor parameter to TYPE_GENERIC Sep 8, 2022
@levon80999 levon80999 requested a review from jmikola September 8, 2022 16:46
jmikola
jmikola requested changes Sep 12, 2022
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the CI failures for this PR. There looks to be another test that requires changes.

In the future, please make a point to come back to PRs on your own and check for failures. Anything that isn't already being tracked in JIRA (e.g. failing-on-waterfall label) should either be fixed or result in a new ticket (if the failure is truly unrelated to the PR).

tests/bson/bson-binary-002.phpt Outdated
Copy link
Member

@jmikola jmikola Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This include is not necessary and can be removed. It was only included in bson-binary-001.phpt for some helper functions used within the test (e.g. fromPHP()).

Copy link
Contributor Author

@levon80999 levon80999 Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@levon80999 levon80999 requested a review from jmikola September 13, 2022 13:55
@levon80999 levon80999 closed this Sep 13, 2022
@levon80999
Copy link
Contributor Author

levon80999 commented Sep 13, 2022

Seems I accidentally closed this PR when tried to solve conflict in phpstorm editor. new PR link is this #1362

@jmikola
Copy link
Member

jmikola commented Sep 13, 2022

Seems I accidentally closed this PR when tried to solve conflict in phpstorm editor.

In the future, you should just be able to re-open the pull request. If you don't have perms to do so, please reach out to @tom-selander.

@alcaeus
Copy link
Member

alcaeus commented Sep 13, 2022

@jmikola that's usually possible, but when force-pushing to a branch that's part of a closed pull request GotHub prevents one from re-opening said PR. I suspect that's what happened here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmikola jmikola Awaiting requested review from jmikola

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@levon80999 @jmikola @alcaeus