PHPC-2486: Require non-null namespace and database arguments in Manager

[alcaeus]

PHPC-2486

I also audited Server.c to confirm that it uses Z_PARAM_STRING in all the right places.

[Copilot]

Pull request overview

This PR aligns MongoDB\Driver\Manager’s internal parameter parsing with its public API contract by disallowing null for database ($db) and namespace ($namespace) arguments in the various execute* methods.

Changes:

• Require non-null database strings for executeCommand, executeReadCommand, executeWriteCommand, and executeReadWriteCommand.
• Require non-null namespace strings for executeQuery and executeBulkWrite.

Comments suppressed due to low confidence (1)

src/MongoDB/Manager.c:292

• This change tightens parameter parsing (db/namespace no longer accepts null). There are many PHPTs covering these execute* methods, but none asserting the new failure mode for null inputs; adding regression tests for executeCommand/executeReadCommand/executeWriteCommand/executeReadWriteCommand and executeQuery/executeBulkWrite with a null first argument would help prevent accidental reintroduction (or potential segfaults if arginfo/type checks are bypassed).

	PHONGO_PARSE_PARAMETERS_START(2, 3)
	Z_PARAM_STRING(db, db_len)
	Z_PARAM_OBJECT_OF_CLASS(command, phongo_command_ce)
	Z_PARAM_OPTIONAL
	Z_PARAM_ZVAL_OR_NULL(options)
	PHONGO_PARSE_PARAMETERS_END();

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[paulinevos]

I know you audited usages, but these are also covered by tests? Do we check coverage in CI actually?

[alcaeus]

I know you audited usages, but these are also covered by tests? Do we check coverage in CI actually?

Nope, we don't have any tests for null parameters. At the moment we don't have any coverage information, I'd like to add that eventually.