Improve error reporting in start-servers.php and fix 3.0 servers #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue introduced in 0f2e387. Trailing colons causes mongod to incorrectly assume the legacy config file produced by MO is in YAML format. We can work around this by swapping the order of the IPv6 and IPv4 addresses.
jmikola
changed the title
derickr
reviewed
Jun 21, 2018
scripts/start-servers.php
Outdated
| return $result; | ||
| } | ||
|
|
||
| function json_decode_or_fail(/* json_decode() args */) |
Contributor
There was a problem hiding this comment.
No variadics for here and the call to json_decode below? http://php.net/manual/en/functions.arguments.php#functions.variable-arg-list
Member
Author
There was a problem hiding this comment.
Not until we drop PHP 5.5 compatibility.
Contributor
There was a problem hiding this comment.
"start-servers.php" doesn't have to be PHP 5.5 compatible though...
| return $ctx; | ||
| } | ||
|
|
||
| function failed($result) { |
Contributor
There was a problem hiding this comment.
I quite liked the failed, with the print, the "last operation time" and the exit. I would rather see this repurposed than deleted.
derickr
approved these changes
Jun 21, 2018
Contributor
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
lgtm (but with a comment)
scripts/start-servers.php
Outdated
| return $result; | ||
| } | ||
|
|
||
| function json_decode_or_fail(/* json_decode() args */) |
Contributor
There was a problem hiding this comment.
"start-servers.php" doesn't have to be PHP 5.5 compatible though...
Member
Author
|
Added variadic args and splat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error reporting for failures in
start-servers.php.Also fixes an issue that prevented 3.0 servers from starting successfully after
bind_ipwas added in 0f2e387 (#850). See SERVER-35705 for more info.