Small fixes for Timestamp and UTCDateTime #857
Conversation
bson_ascii_strtoll() resets errno, so that is no longer necessary. This also removes some outdated comments.
| efree(tmp); | ||
| s_milliseconds_len = snprintf(s_milliseconds, sizeof(s_milliseconds), "%" PRId64, intern->milliseconds); | ||
|
|
||
| PHONGO_RETVAL_STRINGL(s_milliseconds, s_milliseconds_len); |
There was a problem hiding this comment.
What is the reason for making this change? The use of snprintf is potentially unsafe due to strange \0 termination rules, and spprintf is preferred.
There was a problem hiding this comment.
jsonSerialize(), which is effectively the same thing, was already using snprintf() with a static buffer (24 is sufficient to hold INT64_MIN and the null byte).
I don't follow why this would be potentially unsafe. My understanding is that snprintf() always adds a null byte (at the expense of the string it's printing if it were to approach the buffer size). See: https://stackoverflow.com/q/7706936/162228. This makes it safer than sprintf() (risk of no termination) and comparable to spprintf(), which would also always terminate the allocated string.
2 participants
No description provided.