Fix failing tests #1815
Merged
Fix failing tests #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested review from
Copilot and
paulinevos
and removed request for
Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.x #1815 +/- ##
=========================================
Coverage 87.72% 87.72%
Complexity 3195 3195
=========================================
Files 424 424
Lines 6296 6296
=========================================
Hits 5523 5523
Misses 773 773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GromNaN
reviewed
Dec 18, 2025
Comment on lines
+77
to
+83
| 'sessions/snapshot-sessions: Find operation with snapshot' => 'Cluster time is not sent in first command sent out on single-threaded connections (PHPC-2655)', | ||
| 'sessions/snapshot-sessions: Distinct operation with snapshot' => 'Cluster time is not sent in first command sent out on single-threaded connections (PHPC-2655)', | ||
| 'sessions/snapshot-sessions: Aggregate operation with snapshot' => 'Cluster time is not sent in first command sent out on single-threaded connections (PHPC-2655)', | ||
| 'sessions/snapshot-sessions: countDocuments operation with snapshot' => 'Cluster time is not sent in first command sent out on single-threaded connections (PHPC-2655)', | ||
| 'sessions/snapshot-sessions: Mixed operation with snapshot' => 'Cluster time is not sent in first command sent out on single-threaded connections (PHPC-2655)', | ||
| 'sessions/snapshot-sessions: Write commands with snapshot session do not affect snapshot reads' => 'Cluster time is not sent in first command sent out on single-threaded connections (PHPC-2655)', | ||
| 'sessions/implicit sessions default causal consistency: afterClusterTime is not sent on retried read in implicit session when readConcern level is snapshot' => 'Cluster time is not sent in first command sent out on single-threaded connections (PHPC-2655)', |
Member
There was a problem hiding this comment.
Why do you have to skip this tests now, without updating the specifications submodule.
Member
Author
There was a problem hiding this comment.
This branch pulls in the newer extension version, which brings in libmongoc 2.2.1. An issue (CDRIVER-6173) breaks cluster time gossiping for single-threaded connections, breaking these tests.
paulinevos
approved these changes
Dec 18, 2025
GromNaN
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes failing tests related to QE support for bulk writes (PHPLIB-1712) as well as those related to the cluster time gossiping for single-threaded connections (PHPC-2655). Note that while we may fully support QE in bulk writes, this is tested using recently added encryption support in the unified test format which we have not implemented yet (PHPLIB-1630).