Skip to content

Conversation

@jmikola
Copy link
Member

@jmikola jmikola commented Feb 1, 2018

The Operation classes were previously relying on MongoDB\Tests\Collection\FunctionalTestCase, so they required additional changes to initialize a Collection instance for asserting outcome of write operations.

@jmikola jmikola force-pushed the fix-test-namespaces branch from cc74540 to ff2ccf0 Compare February 1, 2018 18:30
@jmikola jmikola requested a review from kvwalker February 1, 2018 18:30
Copy link
Contributor

@kvwalker kvwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

The Operation classes were previously relying on MongoDB\Tests\Collection\FunctionalTestCase, so they required additional changes to initialize a Collection instance for asserting outcome of write operations.
@jmikola jmikola force-pushed the fix-test-namespaces branch from ff2ccf0 to 76cabea Compare February 1, 2018 18:46
@jmikola jmikola merged commit 76cabea into mongodb:master Feb 1, 2018
jmikola added a commit that referenced this pull request Feb 1, 2018
@jmikola jmikola deleted the fix-test-namespaces branch February 1, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants