Skip to content

PHPLIB-278: Add examples for calling methods on database, collection, and index models #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2018
Merged

PHPLIB-278: Add examples for calling methods on database, collection, and index models #522

merged 1 commit into from
Apr 5, 2018

Conversation

@kvwalker
Copy link
Contributor

@kvwalker kvwalker commented Apr 4, 2018

derickr
derickr reviewed Apr 5, 2018
View reviewed changes
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this one depend on PHPLIB-80/PR #521? As I suspect the new getters that you've added there should get documentation like this to.

docs/reference/method/MongoDBModelIndexInfo-isTtl.txt
'expireAfterSeconds' => 100,
]);

var_dump($info->isTtl());
Copy link
Contributor

@derickr derickr Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really use isTtl and not isTTL?

Copy link
Contributor Author

@kvwalker kvwalker Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do!

@kvwalker
Copy link
Contributor Author

kvwalker commented Apr 5, 2018 •
edited
Loading

This doesn't depend on #521 because this is just in response to a user asking for more examples for getName(). I decided to go ahead and add examples for the other methods in the models classes. I can add examples for the other getters to the documentation as part of #521.

derickr
derickr approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kvwalker kvwalker merged commit ce10298 into mongodb:master Apr 5, 2018
kvwalker added a commit that referenced this pull request Apr 5, 2018
@kvwalker
Merge pull request #522
36581b1
@kvwalker kvwalker deleted the PHPLIB-278 branch April 5, 2018 16:18
kvwalker added a commit that referenced this pull request Apr 9, 2018
@kvwalker
Revert "Merge pull request #522"
80dd783 
This reverts commit 36581b1, reversing
changes made to c983951.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@derickr derickr derickr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvwalker @derickr