PHPLIB-718: APM spec tests for serverConnectionId #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
May 16, 2022
Member
There was a problem hiding this comment.
The two test failures are related to known sharded cluster failures, so it looks like the new tests pass.
Please remove the TODO I mentioned below and update the diff to avoid stripping newlines from the existing spec test files.
When merging, the commit message can simply be:
PHPLIB-718: APM spec tests for serverConnectionId
...with no additional lines.
| } | ||
| ] | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Please remove these changes from the PR.
Looking at the corresponding files in the specifications repo (e.g. server-connection-id.json), those do have trailing newlines. This looks like this change may be been introduced by your local environment (not sure if that may be a git configuration or your IDE).
jmikola
changed the title
jmikola
reviewed
May 16, 2022
jmikola
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-718