PYTHON-5748 Remove unused SpecRunner class#2725
Merged
ShaneHarvey merged 1 commit intomongodb:masterfrom Mar 9, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the unused legacy spec runner classes from the spec runner utilities, reducing dead code in the test harness while keeping the parts still referenced by existing spec-based tests.
Changes:
- Removed the unused
SpecRunnerclass (sync) andAsyncSpecRunnerclass (async) along with their now-unused helper functions/imports. - Slimmed down
utils_spec_runnermodules to retain onlySpecRunnerThread/SpecRunnerTaskand theSpecTestCreator/AsyncSpecTestCreatorfunctionality used by current tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/utils_spec_runner.py | Removes unused SpecRunner implementation and associated imports/helpers; keeps thread + test creator utilities used by other tests. |
| test/asynchronous/utils_spec_runner.py | Removes unused AsyncSpecRunner implementation and associated imports/helpers; keeps task + async test creator utilities used by other tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5748 Remove unused SpecRunner class