Skip to content

Use errorContains: E11000 in all spec tests formerly referencing DuplicateKey #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Use errorContains: E11000 in all spec tests formerly referencing DuplicateKey #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b35ae44
Use errorContains: E11000 in all spec tests formerly referencing Dupl…
p Sep 9, 2019
5d892e3
Guard against shards being empty
p Sep 9, 2019
9cf20c7
Fix multiple mongos requirement to only apply in sharded topologies
p Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec/spec_tests/data/transactions/abort.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,10 @@ tests:
document:
_id: 1
result:
# Don't assert on errorCodeName because (after SERVER-38583) the
# DuplicateKey is reported in writeErrors, not as a top-level
# command error.
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
# DuplicateKey error code included in the bulk write error message
# returned by the server
errorContains: E11000
# Make sure the server aborted the transaction.
- name: insertOne
object: collection
Expand Down
6 changes: 3 additions & 3 deletions spec/spec_tests/data/transactions/error-labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ tests:
- _id: 1
- _id: 1
result:
# Don't assert on errorCodeName because (after SERVER-38583) the
# DuplicateKey is reported in writeErrors, not as a top-level
# command error.
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
# DuplicateKey error code included in the bulk write error message
# returned by the server
errorContains: E11000
- name: abortTransaction
object: session0

Expand Down
6 changes: 3 additions & 3 deletions spec/spec_tests/data/transactions_api/callback-retry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,10 @@ tests:
result:
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
result:
# Don't assert on errorCodeName because (after SERVER-38583) the
# DuplicateKey is reported in writeErrors, not as a top-level
# command error.
errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
# DuplicateKey error code included in the bulk write error message
# returned by the server
errorContains: E11000
expectations:
-
command_started_event:
Expand Down
3 changes: 3 additions & 0 deletions spec/support/cluster_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ def storage_engine
client = ClientRegistry.instance.global_client('root_authorized')
if topology == :sharded
shards = client.use(:admin).command(listShards: 1).first
if shards['shards'].empty?
raise 'Shards are empty'
end
shard = shards['shards'].first
address_str = shard['host'].sub(/^.*\//, '').sub(/,.*/, '')
client = ClusterTools.instance.direct_client(address_str,
Expand Down
2 changes: 1 addition & 1 deletion spec/support/transactions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def define_transactions_spec_tests(test_paths)

before do
if test.multiple_mongoses?
unless SpecConfig.instance.addresses.length > 1
if ClusterConfig.instance.topology == :sharded && SpecConfig.instance.addresses.length == 1
skip "Test requires multiple mongoses"
end
else
Expand Down