RUBY-2060 Pin mlaunch version on evergreen #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
reviewed
Jan 3, 2020
| end | ||
| end | ||
|
|
||
| shared_examples_for 'auth mechanism that uses database or default auth source' do |default_auth_source:| |
Contributor
There was a problem hiding this comment.
Would do |default_auth_source: nil| fix this also?
Contributor
Author
There was a problem hiding this comment.
I was going to try that next. Let's see!
Contributor
Author
There was a problem hiding this comment.
I tried that out, and rspec seems to think that I'm not passing in any value for default_auth_source. I know that keyword arguments are changing in Ruby 2.7/3, but I believe the existing syntax should still work, so I'm not sure how that's related.
How would you feel about just removing the keyword argument for now?
egiurleo
changed the title
p-mongo
approved these changes
Jan 6, 2020
p-mongo
pushed a commit
that referenced
this pull request
Jan 6, 2020
* pin mlaunch version * remove keyword argument from spec * Re-running tests
p-mongo
pushed a commit
that referenced
this pull request
Jan 6, 2020
* pin mlaunch version * remove keyword argument from spec * Re-running tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.