Skip to content

Conversation

@egiurleo
Copy link
Contributor

It looks like libmongocrypt has changed some of its KMS endpoint validation behavior -- now calling the Amazon KMS endpoint via https is valid, and the data key context object also performs some endpoint validation. This does not impact the user experience with FLE.

@egiurleo egiurleo requested a review from p-mongo October 20, 2020 14:07
Copy link
Contributor

@p-mongo p-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make a ticket with the error message we are getting on master and a quote of the parameters we are using that results in that message?

@egiurleo
Copy link
Contributor Author

What error message are you referring to? This one?

      Failure/Error:
        expect do
          context
        end.not_to raise_error
      
        expected no Exception, got #<Mongo::Error::CryptError: Invalid endpoint, expected .: endpoint/to/kms (libmongocrypt error code 1)> with backtrace:

raised by

rspec ./spec/mongo/crypt/data_key_context_spec.rb:193 # Mongo::Crypt::DataKeyContext#initialize with aws kms provider with valid endpoint does not raise an exception

@egiurleo egiurleo merged commit 045c80b into mongodb:master Oct 21, 2020
p-mongo pushed a commit that referenced this pull request Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants