Fix failing atlas connectivity specs #2829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo
suggested changes
Jan 25, 2024
Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
comandeo
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Atlas connectivity specs were failing when testing the "free tier" atlas URI, because the "ismaster" command wasn't returning the expected results.
Looking at the Go and Python drivers, it looks like they are only testing for the absence of an error when executing these commands; the original ticket (https://jira.mongodb.org/browse/DRIVERS-382) also stipulates that drivers should merely "verify that no error occurred." I've updated the specs so they no longer check for the contents of the result, and only confirm that no error occurred.