Skip to content

Conversation

@norareidy
Copy link
Contributor

@norareidy norareidy commented Feb 26, 2024

@norareidy norareidy marked this pull request as ready for review February 26, 2024 21:42
Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion.

or avoid setting ``api_strict: true`` when constructing ``Mongo::Client``
instances with server versions 5.0.0-5.0.7 and 5.1.0-5.3.1.
- The DBRef class has been moved to bson-ruby. For backwards compatibility,
- The DBRef class has been moved to ``bson-ruby``. For backwards compatibility,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Since DBRef is a class name, I think formatting with monospace would make this consistent:

Suggested change
- The DBRef class has been moved to ``bson-ruby``. For backwards compatibility,
- The ``DBRef`` class has been moved to ``bson-ruby``. For backwards compatibility,

@jamis jamis merged commit 517891b into mongodb:2.19-stable Feb 28, 2024
@norareidy norareidy deleted the DOCSP-37137-fix-bson-references branch February 28, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants