Skip to content

RUBY-842 populate error code when using write commands #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estolfo merged 1 commit into from
Dec 8, 2014
Merged

RUBY-842 populate error code when using write commands #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/mongo/db.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,9 @@ def command(selector, opts={})
end.join('; ')
message << ').'
code = result['code'] || result['assertionCode']
if result['writeErrors']
code = result['writeErrors'].first['code']
end
raise ExecutionTimeout.new(message, code, result) if code == MAX_TIME_MS_CODE
raise OperationFailure.new(message, code, result)
end
Expand Down
12 changes: 12 additions & 0 deletions test/functional/collection_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,18 @@ def test_update_write_command_with_error
end
end

def test_error_code
coll = @db['test-error-code']
coll.ensure_index(BSON::OrderedHash[:x, Mongo::ASCENDING], { :unique => true })
coll.save(:x => 2)
begin
coll.save(:x => 2)
rescue => ex
assert_not_nil ex.error_code
end
coll.drop
end

def test_aggregation_cursor
return unless @version >= '2.5.1'
[10, 1000].each do |size|
Expand Down