-
Notifications
You must be signed in to change notification settings - Fork 533
RUBY-1140 Add TLS SNI support #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seems reasonable, but having run into issues in Java you should do some manual testing for the following cases:
for both MRI and JRuby. |
|
LGTM |
|
This doesn't seem to work for JRuby. I'm setting the hostname as indicated here but the server logs show: for MRI, it shows: |
|
If JRuby doesn't support it (it's undocumented in MRI, so no surprise) then oh well. Open a ticket against MRI to get it documented, and against JRuby to get it implemented. I couldn't implement it for all the versions of python we support either. |
|
So in the Python driver, you only set the hostname for certain versions of Python? |
|
Yep, only versions of python that support SNI. |
805e063 to
8d420f6
Compare
|
There's a claim that it's implemented here: jruby/jruby#349. But the comment saying that SNI is supported starting with Java 7 doesn't jibe with my experience. The Java driver's SNI support relies on a Java 8 feature: https://docs.oracle.com/javase/8/docs/api/javax/net/ssl/SSLParameters.html#setServerNames-java.util.List- |
|
I opened a ticket with the openssl library for JRuby. Hopefully I'll get some more info soon from the JRuby team directly... |
|
fyi, the Ruby team updated their docs: https://bugs.ruby-lang.org/issues/12740 |
8d420f6 to
3993487
Compare
|
Cannot support this for JRuby until they resolve the bug in openssl: |
No description provided.