Be more defensive in native extension. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
p-mongo
commented
Oct 25, 2018
p-mongo
commented
- Explicitly reserve a byte for null terminator in strings
- Only close the connection being worked on with sasl_dispose rather than all of them
- Explicitly reserve a byte for null terminator in strings - Only close the connection being worked on with sasl_dispose rather than all of them
saghm
reviewed
Dec 18, 2018
| /* from now on context owns conn */ | ||
| /* since mongo_sasl_conn_free cleans up conn, we should NOT call */ | ||
| /* sasl_dispose any more in this function. */ | ||
| RB_GC_GUARD(context); |
Contributor
There was a problem hiding this comment.
I think this should be moved to below line 120? From what I can tell in the docs, RB_GC_GUARD) only guards the context up to the point where the macro is invoked, and so I think we want this invocation to be below the last usage of context.
| result = sasl_encode64(raw_payload, raw_payload_len, encoded_payload, sizeof(encoded_payload), &encoded_payload_len); | ||
| /* I can't tell if the buffer size expected by sasl_encode64 includes */ | ||
| /* the null terminator, thus be defensive and exclude it */ | ||
| result = sasl_encode64(raw_payload, raw_payload_len, encoded_payload, sizeof(encoded_payload)-1, &encoded_payload_len); |
Contributor
There was a problem hiding this comment.
Looks to me like it's documented as null-terminated: https://docs.oracle.com/cd/E86824_01/html/E54774/sasl-encode64-3sasl.html
Contributor
Author
|
Made the requested changes. |
saghm
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.