Skip to content

Write config - default to the connection string writeconcern is avail… #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rozza merged 1 commit into from
May 1, 2025
Merged

Write config - default to the connection string writeconcern is avail… #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/com/mongodb/spark/sql/connector/config/WriteConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,10 @@ private String getNamespaceDescription(final CollectionsConfig collectionsConfig
}

private WriteConcern createWriteConcern() {
WriteConcern writeConcern = WriteConcern.ACKNOWLEDGED;
WriteConcern writeConcern = getConnectionString().getWriteConcern();
if (writeConcern == null) {
writeConcern = WriteConcern.ACKNOWLEDGED;
Copy link
Member

@stIncMale stIncMale Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional]

To make it obvious for a code reader that the default write concern is the same as that in the MongoClientSettings, we could write MongoClientSettings.builder().build().getWriteConcern() instead of WriteConcern.ACKNOWLEDGED.

We may further document on WriteConfig.WRITE_CONCERN_W_CONFIG that the default write concern is the same as the one used by MongoClientSettings, which is WriteConcern.ACKNOWLEDGED.

}
try {
if (containsKey(WRITE_CONCERN_W_CONFIG)) {
try {
Expand Down
12 changes: 12 additions & 0 deletions src/test/java/com/mongodb/spark/sql/connector/config/MongoConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,18 @@ void testMongoConfigWriteConcern() {
writeConfig = writeConfig.withOption(
WriteConfig.WRITE_PREFIX + WriteConfig.WRITE_CONCERN_W_CONFIG, "region1");
assertEquals(new WriteConcern("region1"), writeConfig.getWriteConcern());

writeConfig = MongoConfig.createConfig(CONFIG_MAP).toWriteConfig();
writeConfig.withOption(MongoConfig.CONNECTION_STRING_CONFIG, "mongodb://localhost/");
assertEquals(WriteConcern.ACKNOWLEDGED, writeConfig.getWriteConcern());

writeConfig = writeConfig.withOption(
MongoConfig.CONNECTION_STRING_CONFIG, "mongodb://localhost/?w=majority");
assertEquals(WriteConcern.MAJORITY, writeConfig.getWriteConcern());

// Explicit configuration beats connection string
writeConfig = writeConfig.withOption(WriteConfig.WRITE_CONCERN_W_CONFIG, "3");
assertEquals(3, writeConfig.getWriteConcern().getW());
}

@Test
Expand Down