Fixed warnings #242
Merged
Fixed warnings #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
suggested changes
Apr 18, 2019
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
Thanks for the PR! There are just a couple changes needed to satisfy SwiftLint on Travis. We'll be tagging the release this afternoon so would be great if we can get this in before then!
Contributor
Author
|
done 👍 |
kmahar
approved these changes
Apr 18, 2019
Contributor
kmahar
left a comment
kmahar
left a comment
There was a problem hiding this comment.
LGTM, thanks @valeriomazzeo !!
mbroadst
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internaldeclaration that were triggering warnings on Xcode 10.2AnyBSONValueconformance toHashable