SWIFT-134 Write a release script #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
May 23, 2019
| @$(call check_for_gem,xcodeproj) | ||
| ruby Tests/Scripts/add_json_files.rb | ||
|
|
||
| sourcery: |
There was a problem hiding this comment.
Since sourcery is now also used to update MongoSwift.swift I renamed this to be more specific.
| install: ./Tests/Scripts/install_dependencies.sh sourcery | ||
| before_script: skip | ||
| script: ${PWD}/sourcery/bin/sourcery; git diff --exit-code Tests/LinuxMain.swift | ||
| script: export sourcery=${PWD}/sourcery/bin/sourcery; make linuxmain; git diff --exit-code Tests/LinuxMain.swift |
There was a problem hiding this comment.
export needed so makefile can find sourcery
|
Once we have consensus on this I can add a similar script to the mobile repo. |
patrickfreed
approved these changes
May 28, 2019
mbroadst
reviewed
May 29, 2019
| @@ -0,0 +1,30 @@ | |||
| // swiftlint:disable:previous vertical_whitespace | |||
There was a problem hiding this comment.
Two thoughts:
- could we just have a
MongoSwiftVersion.swift(orVersion.swift) that adds aprivate static let versionStringto the right namespace. It seems like there is other stuff going on in this file that we don't want to be templated - somewhat crazier, but could be nice, can you encode the version into the
Package.swiftand dynamically read it from that file at runtime?Package.swiftwill always be there, in a known fixed location
There was a problem hiding this comment.
I went with the first!
| rm ${PWD}/MongoSwift.podspec | ||
|
|
||
| # go to GitHub to publish release notes | ||
| open "https://github.com/mongodb/mongo-swift-driver/releases/tag/v${1}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a release script. For obvious reasons, I have not actually executed the full script in our repo and cannot say with certainty that this will work in its entirety, but I have tested most of it in pieces.