Skip to content

Conversation

@pooooodles
Copy link

@pooooodles pooooodles commented Jan 12, 2021

Added a step to file a DOCSP ticket outlining compatibility changes or lack thereof

@pooooodles pooooodles changed the title Added a step to file a DOCSP ticket outlining compatibility changes o… Update release checklist with step to file a DOCSP ticket Jan 12, 2021
@sync-by-unito sync-by-unito bot changed the title Update release checklist with step to file a DOCSP ticket SWIFT-1053 ⁃ Update release checklist with step to file a DOCSP ticket Jan 12, 2021
@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #573 (40173d0) into master (042bdba) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   76.57%   76.56%   -0.02%     
==========================================
  Files         151      151              
  Lines       16268    16268              
==========================================
- Hits        12457    12455       -2     
- Misses       3811     3813       +2     
Impacted Files Coverage Δ
Sources/MongoSwift/EventLoopBoundMongoClient.swift 60.00% <0.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 042bdba...40173d0. Read the comment docs.

Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @agolin95 !!

Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry I missed this PR in my inbox so took me a little while to get to it.

@pooooodles pooooodles changed the title SWIFT-1053 ⁃ Update release checklist with step to file a DOCSP ticket SWIFT-SWIFT-1053 ⁃ Update release checklist with step to file a DOCSP ticket Jan 19, 2021
@pooooodles pooooodles merged commit 8e7a0ff into master Jan 19, 2021
@pooooodles pooooodles deleted the SWIFT-1035 branch January 19, 2021 16:43
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 19, 2021

➤ Githook User commented:

Author:{'name': 'Alexander Golin', 'email': 'agolin95@gmail.com', 'username': 'agolin95'}
Message: SWIFT-SWIFT-1053 ⁃ Update release checklist with step to file a DOCSP ticket (#573)
Branch: master
8e7a0ff

@pooooodles pooooodles changed the title SWIFT-SWIFT-1053 ⁃ Update release checklist with step to file a DOCSP ticket SWIFT-1053 ⁃ Update release checklist with step to file a DOCSP ticket Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants