SWIFT-1293 Add support for loadBalanced option #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
Aug 11, 2021
| self.readConcern = rc | ||
| } | ||
|
|
||
| if let replicaSet = options?.replicaSet { |
Contributor
Author
There was a problem hiding this comment.
I needed to move this since some of the validation in applyAndValidateSDAMOptions relies on the value of this. it also seems like this probably should have been in that method anyway since it's an option related to SDAM
patrickfreed
approved these changes
Aug 12, 2021
kmahar
force-pushed
the
SWIFT-1293/loadBalanced-option
branch
from
57b4ba2 to
e02b4f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is atop the
vendor-libmongocbranch, will change base tomainafter that PR gets merged.