SWIFT-1310, SWIFT-1307: Make unified test runner changes needed for load balancer testing, expose serviceID in command monitoring events #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
Aug 17, 2021
| } | ||
| } | ||
|
|
||
| struct UnifiedCreateFindCursor: UnifiedOperationProtocol { |
Contributor
Author
There was a problem hiding this comment.
| guard let next = cs.next() else { | ||
| throw TestError(message: "Change stream unexpectedly exhausted") | ||
| let entity = try context.entities.getEntity(from: object) | ||
| switch entity { |
Contributor
Author
There was a problem hiding this comment.
this operation now supports multiple target types: https://github.com/mongodb/specifications/blob/master/source/unified-test-format/unified-test-format.rst#iterateuntildocumentorerror
accordingly, I renamed this file since the operations aren't just change stream specific anymore
| } | ||
| } | ||
|
|
||
| struct UnifiedCloseCursor: UnifiedOperationProtocol { |
Contributor
Author
There was a problem hiding this comment.
patrickfreed
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is all the test runner changes we need for load balancer support, except perhaps support for reading in the load balancer URIs, but I think it makes sense to wait til I'm actually at the stage of running new load balancer tests to figure that part out.
Since the runner needed capability to assert on serviceID in command monitoring events, I added that property to the events as well here.